search

yandex / speechkitcloud

Speechkit Cloud examples and SDK
Apache License 2.0
89 stars 45 forks source link

Add an snrWasUsed field #31

Closed dfyz closed 7 years ago

dfyz commented 7 years ago

Will be set to true only if the SNR system actually did some rescoring (we need this for experiment analysis).

simakazi commented 7 years ago

Why wouldn't you like to use 'snrResponseCode == 200' check?

dfyz commented 7 years ago

'snrResponseCode == 200' check

This is not exactly what I need. SNR has a "no-op" mode that doesn't rescore anything and is activated when a disrepancy is detected between the SpeechKit version SNR was trained on and the metainfo.version field value. SNR still returns 200 OK when this happens, which means a simple == 200 check won't do.

Perhaps we could come up with a better field name. snrNoOpMode? snrWasActive?

simakazi commented 7 years ago

Maybe you could use something like 304 NOT MODIFIED in SNR response code for such a case?

dfyz commented 7 years ago

Sounds like a fine idea, but we still have to calculate candidate features and store them in metainfo.snrInfos.features. Even for the no-op mode.

There are other HTTP codes we could use, but this seriously seems like abusing HTTP. :/