yandex / yandex-tank

Load and performance benchmark tool
Other
2.46k stars 278 forks source link

jmeter custom log cause an empty stats in yandex-tank #106

Closed maklaut closed 9 years ago

maklaut commented 10 years ago

I have a problem with executing jmeter tests from yandex-tank. When I start jmeter test by yandex-tank it is successfuly executed. But I can't see the current test status (look at screen shot). The only I can see is summary info from jmeter console (with short_only=1 console option).

jmeter-yandex-tank

maklaut commented 10 years ago

The reason of problem was a custom log variables in user.properties:

sample_variables=var1,var2,var3,var4,var5

Additional columns in jmeter.jtl considered by tank as a "wrong line".

Now I'm using this patch to fix it:

diff --git a/Tank/Plugins/JMeter.py b/Tank/Plugins/JMeter.py
index 62aa89d..f8c9d7a 100644
--- a/Tank/Plugins/JMeter.py
+++ b/Tank/Plugins/JMeter.py
@@ -274,9 +274,9 @@ class JMeterReader(AbstractReader):
                     line = self.partial_buffer + line
                     self.partial_buffer = ''
                 data = line.rstrip().split("\t")
-                if line[-1] != '\n' or len(data) != 9:
+                if line[-1] != '\n' or len(data) < 9:
                     self.partial_buffer = line
                    # self.log.warning("Wrong jtl line, skipped: %s", line)
                     continue