search

yandex / yandex-taxi-testsuite

testsuite: microservices testing framework
MIT License
144 stars 38 forks source link

support RabbitMQ #12

Closed itrofimow closed 2 years ago

itrofimow commented 2 years ago

Addresses https://github.com/yandex/yandex-taxi-testsuite/issues/11

itrofimow commented 2 years ago

@vitek Could you please have a look at this?

itrofimow commented 2 years ago

What should i do with python3.6 build failing? it EOL-ed 7 months ago (https://endoflife.date/python), and recent versions of aio-pika no longer support it.

vitek commented 2 years ago

Currently userver provides support for xenial. So testsuite should run there as well. 3.6 support may be a reason to use sync driver.

On Thu, 28 Jul 2022 at 17:00, itrofimow @.***> wrote:

What should i do with python3.6 build failing? it's EOL-ed 7 months ago, and recent versions of aio-pika no longer support it.

— Reply to this email directly, view it on GitHub https://github.com/yandex/yandex-taxi-testsuite/pull/12#issuecomment-1198182677, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXPXYUMPBFFLWTU6NZEFDVWKG6DANCNFSM54VV6F2A . You are receiving this because you were mentioned.Message ID: @.***>

-- Victor Makarov.

itrofimow commented 2 years ago

Currently userver provides support for xenial. So testsuite should run there as well. 3.6 support may be a reason to use sync driver. On Thu, 28 Jul 2022 at 17:00, itrofimow @.> wrote: What should i do with python3.6 build failing? it's EOL-ed 7 months ago, and recent versions of aio-pika no longer support it. — Reply to this email directly, view it on GitHub <#12 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXPXYUMPBFFLWTU6NZEFDVWKG6DANCNFSM54VV6F2A . You are receiving this because you were mentioned.Message ID: @.> -- Victor Makarov.

I see 2 options here:

  1. Blocking version
  2. Freezing async version at something appropriate, falling back to 1 if it doesn't work

What would be your call?

itrofimow commented 2 years ago

@vitek i did freeze underlying driver version, making it python3.6 compatible and asyncio-based

Does this pr require any other changes?

vitek commented 2 years ago

Freeze it only for py36 please. I’ll take a look later

On Mon, 1 Aug 2022 at 16:35, itrofimow @.***> wrote:

@vitek https://github.com/vitek i did freeze underlying driver version, making it python3.6 compatible and asyncio-based

Does this pr require any othet changes?

— Reply to this email directly, view it on GitHub https://github.com/yandex/yandex-taxi-testsuite/pull/12#issuecomment-1201214731, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXPX3JU3DZ4VACL3DOKWDVW7HAZANCNFSM54VV6F2A . You are receiving this because you were mentioned.Message ID: @.***>

-- Victor Makarov.

vitek commented 2 years ago

@vitek i did freeze underlying driver version, making it python3.6 compatible and asyncio-based

Does this pr require any other changes?

See this for example https://github.com/yandex/yandex-taxi-testsuite/blob/develop/setup.py#L16

vitek commented 1 year ago

Go on with sync version

On Thu, 28 Jul 2022 at 18:08, itrofimow @.***> wrote:

Currently userver provides support for xenial. So testsuite should run there as well. 3.6 support may be a reason to use sync driver. On Thu, 28 Jul 2022 at 17:00, itrofimow @.> wrote: What should i do with python3.6 build failing? it's EOL-ed 7 months ago, and recent versions of aio-pika no longer support it. — Reply to this email directly, view it on GitHub <#12 (comment) https://github.com/yandex/yandex-taxi-testsuite/pull/12#issuecomment-1198182677>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXPXYUMPBFFLWTU6NZEFDVWKG6DANCNFSM54VV6F2A https://github.com/notifications/unsubscribe-auth/AADXPXYUMPBFFLWTU6NZEFDVWKG6DANCNFSM54VV6F2A . You are receiving this because you were mentioned.Message ID: @.> -- Victor Makarov.

I see 2 options here:

  1. Blocking version
  2. Freezing async version at something appropriate, falling back to 1 if it doesn't work

What would be your call?

— Reply to this email directly, view it on GitHub https://github.com/yandex/yandex-taxi-testsuite/pull/12#issuecomment-1198283773, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADXPX4JKQZOPJEBQV4YVO3VWKO7BANCNFSM54VV6F2A . You are receiving this because you were mentioned.Message ID: @.***>

-- Victor Makarov.