[Week 10] Migrate to gymnasium

yandexdataschool / Practical_RL

A course in reinforcement learning in the wild

The Unlicense

5.92k stars 1.7k forks source link

[Week 10] Migrate to gymnasium #534

Closed laktionov closed 1 year ago

laktionov commented 1 year ago

Support new interfaces in seminar notebook
Change done to terminated or truncated to iterate over env

review-notebook-app[bot] commented 1 year ago

Check out this pull request on

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

kharitonov-ivan commented 1 year ago

Hi! Thx for PR. Let me see.

laktionov commented 1 year ago

Hi, in this case CartPole-v1 with max_episode_steps=200 is equivalent to CartPole-v0 and the update has been made in order not to face with an annoying warning.

kharitonov-ivan commented 1 year ago

@laktionov I've looked it over, added a few comments, otherwise all good.

dniku commented 1 year ago

Thanks!