proposing corrections for week01 seminar

[lopezjuanma96]

Just finished the week01 of the blog course. This is awesome! I'm learning a lot - although I have to say I'm skipping most of the complex formulas, not my string point -. In any case, found a few modifications that I feel could be of use. Hope they are of help, I'll continue with the week02 these next days.

• size is now vector_size in Word2Vec
• added print for model save path on gensim's api.load
• corrected PCA's bold initials, since asteriks seem to be best practice and some viewers don't work with underscores

[review-notebook-app[bot]]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[justheuristic]

Hi! Sorry for the late response. The week1 changes are perfect, but some of the changes you propose to week3 include solutions, e.g.

Our format requires that these notebooks are handout assignments that do not include solutions.

If you modify the code to exclude your solution, i'd be happy to merge this PR

[lopezjuanma96]

Oh that's bad, it seems the commit for my solutions got mixed up in the pull request.. Is there any way you can use the corrections for week01? If not I'll try to make them on a separate branch.

Btw, now that I am about a half into the course I have to tell you it is amazing what you've done. I'm thinking of applying to the online courses at Yandex at some point.

Thank you for your response, hope we can be in touch.

Juanma

El jue, 21 sep. 2023 12:20, justheuristic @.***> escribió:

Hi! Sorry for the late response. The week1 changes are perfect, but some of the changes you propose to week3 include solutions, e.g.

[image: image] https://user-images.githubusercontent.com/3491902/269667056-a4da891d-4f3e-4ae3-8f0f-d6f361986a3e.png

If you modify the code to exclude your solution, i'd be happy to merge

— Reply to this email directly, view it on GitHub https://github.com/yandexdataschool/nlp_course/pull/117#issuecomment-1729800779, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALUJ5APW7HUIDO2LQCO2HTTX3RLMNANCNFSM6AAAAAA32YK6F4 . You are receiving this because you authored the thread.Message ID: @.***>

[poedator]

Hi, @lopezjuanma96 to save your work locally you may want to create a new branch from the latest commit here. Then reset your 2022 branch to your original commit a27bfac and summon @justheuristic.

For additional contributions please use branch 2023

note to ourselves: pick this PR result into 2023 branch.

[lopezjuanma96]

I had a separate branch for solutions but it would seem i messed up and push some commits with solutions on main branch.

Okey, I'll try my best to do so, I can't promise I'll be successful in my first try, but I'll tell you when I'm done and we can recheck.

[poedator]

replaced with #151