search

yandexdataschool / nlp_course

YSDA course in Natural Language Processing
https://lena-voita.github.io/nlp_course.html
MIT License
9.83k stars 2.61k forks source link

fixed fd leakage #118

Closed galqiwi closed 1 year ago

galqiwi commented 1 year ago

Code like list(open("./quora.txt")) leaks file descriptors, as it does not call .close() method on file. It's better to use it with with.

review-notebook-app[bot] commented 1 year ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

yuboona commented 1 year ago

您的邮件我已收到，将尽快回复！！