search

yandexdataschool / nlp_course

YSDA course in Natural Language Processing
https://lena-voita.github.io/nlp_course.html
MIT License
9.84k stars 2.61k forks source link

week 3, seminar, Kneser-Ney smoothing formula #12

Closed ilivans closed 6 years ago

ilivans commented 6 years ago

There must be a bug in Kneser-Ney smoothing formula image The denominator shouldn't contain a subtraction of delta from counts. First of all, denominator becomes 0 in some cases. Also there is no delta in denominator at the lecture slides and wiki page.

justheuristic commented 6 years ago

Thanks! Will fix it right away