search

yandexmobile / react-native-appmetrica

React Native bridge to the AppMetrica on both iOS and Android.
MIT License
52 stars 132 forks source link

Error reporting crashes at android #12

Open zwerg44 opened 6 years ago

zwerg44 commented 6 years ago

version: 0.1.1 os: android 6.0.1

Function reportError crashes.

I tried both:

Javascript code always passes 2 arguments to its native bridge link

In the android bridge there is no second argument link

That produces crash: com.facebook.react.bridge.NativeArgumentsParseException: AppMetrica.reportError got 2 arguments, expected 1 at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:355) at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:162) at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method) at android.os.Handler.handleCallback(Handler.java:739) at android.os.Handler.dispatchMessage(Handler.java:95) at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31) at android.os.Looper.loop(Looper.java:148) at com.facebook.react.bridge.queue.MessageQueueThreadImpl$3.run(MessageQueueThreadImpl.java:194) at java.lang.Thread.run(Thread.java:818)

zwerg44 commented 6 years ago

looks like there is fix in this fork https://github.com/10levels/react-native-appmetrica/commit/0de3bc30c221eb0c1001946d3e5a7473e88caefc