yandod / candycane

a port of Redmine to CakePHP from Ruby on Rails
http://my.candycane.jp
510 stars 127 forks source link

Bulk move is not working #279

Open yaras opened 8 years ago

yaras commented 8 years ago

I go to issues list, then I select multiple tasks and open context menu in which I select Move and I get:

An Internal Error Has Occurred. Error: An Internal Error Has Occurred.

After I dug into code I found two issues:

First, move method checks:

but it does not check request->query['ids'], which should be done as bulk move adds ids query param.

Second, instead of $this->cakeError there should be thrown an exception, for example BadRequestException.

This is already reported in #278.

I also try to fix this issue and open a pull request with my fix proposal.