search

yandod / candycane

a port of Redmine to CakePHP from Ruby on Rails
http://my.candycane.jp
510 stars 127 forks source link

Add unique id to changelog checkbox tracker element and replace "label" for "div" #281

Open yaras opened 8 years ago

yaras commented 8 years ago

Add unique id to changelog checkbox tracker element

Without this all checkboxes have same id. Labels' "for" attributes point to all checkboxes and after click on any label always first was checked.

This applies to http://< url >/candycane/projects/< project >/changelog

Replace element "label" for "div" in sidebar/changelog.ctp

Element "label" should not be used for grouping other HTML elements: https://www.w3.org/TR/html5/forms.html#the-label-element

This also removes unnecessary float on checkboxes.

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 47.111% when pulling 9d45c975fbf1d2506d6f27dc37e7d1c6029a24e2 on yaras:fix/label into 8814533099b3d26c9f6f18a0c5f5a373b8b158c8 on yandod:master.