Fix wasm build - Githubissues

yaneurao / YaneuraOu

YaneuraOu is the World's Strongest Shogi engine(AI player) , WCSC29 1st winner , educational and USI compliant engine.

GNU General Public License v3.0

512 stars 140 forks source link

Fix wasm build #265

Closed WandererXII closed 1 year ago

WandererXII commented 1 year ago

Fixing wasm build.

USE_PTHREADS is deprecated - https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3134---031423
TOTAL_STACK was renamed to STACK_SIZE - https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3125---110822
LLD_REPORT_UNDEFINED was removed, it's always default now - https://github.com/emscripten-core/emscripten/blob/main/ChangeLog.md#3125---110822
-march=wasm32 throws errors, so I just removed it

I tested k-p version and it worked.

yaneurao commented 1 year ago

Great job, I'm very happy with it.

yaneurao commented 10 months ago

I am not sure if it's related to this issue, but since the following commit, the wasm build has been failing with an error. If you can figure out the cause, could you please help?

https://github.com/yaneurao/YaneuraOu/actions/runs/6764541028

WandererXII commented 10 months ago

Probably this: https://github.com/emscripten-core/emscripten/pull/20671 I will lock the emscripten instead of using latest, which will just keep breaking.