search

yang-wei / rd3

react + d3
https://yang-wei.github.io/rd3/
MIT License
319 stars 83 forks source link

changes to elimate deprication warnings from react. Introduces two ne… #108

Closed brantphoto closed 7 years ago

brantphoto commented 7 years ago

for yang-wei/rd3/issues/106

@yang-wei This pull request replaces React.PropTypes and React.createClass(). Note that that means that there are now two more dependencies, 'create-react-class' and 'prop-types', so I would consider that when figuring out the version number.

brantphoto commented 7 years ago

@yang-wei does this look ok? Are you still taking pull requests or is there another maintainer? Thanks in advance.

brantphoto commented 7 years ago

Hi @yang-wei, just wanted to check in to see if this PR is acceptable. If you aren't maintaining the repo can you reply so I'll know to fork? Thanks!

yang-wei commented 7 years ago

@brantphoto Wow thanks for this pull request. I will definitely accept this and really apologize for the late response. Just want to check if any files is missing and will definitely give this a go

yang-wei commented 7 years ago

will make this into 0.8.0 version =)