search

yang-wei / rd3

react + d3
https://yang-wei.github.io/rd3/
MIT License
319 stars 83 forks source link

Added documentation on the accessors and slight mod of the responsive exemple #83

Closed BenjaminPoilve closed 8 years ago

BenjaminPoilve commented 8 years ago

So as we said: •I added the accessor to the documentation •Documented the .y0 accessor

I also modified the responsive exemple, as I think duration is not needed and the syntax I proposed is more common than the :: used.

If this is not good github etiquette to ask for two different changes, tell me and I'll split the pull request. Since both issues were in the doc, I felt like I could do both.

yang-wei commented 8 years ago

I think you only have to change the doc for barChart. For property xAccessor and yAccessor they live in https://github.com/yang-wei/rd3/blob/master/docs/new/cartesianChartPropsMixin.md

For the changes in docs/new/responsiveCharts.md, I prefer another pr because it has nothing to do with https://github.com/yang-wei/rd3/pull/82

Thanks for you effort