search

yangao07 / abPOA

abPOA: an SIMD-based C library for fast partial order alignment using adaptive band
MIT License
111 stars 18 forks source link

make install using prefix does not set rpath #33

Closed EricDeveaud closed 2 years ago

EricDeveaud commented 2 years ago

Hello

using release taged archive for version 1.2.5 (https://github.com/yangao07/abPOA/releases/download/v1.2.5/abPOA-v1.2.5.tar.gz)

when abPOA is built using a prefix location make install does not set rpath to $PREFIX/lib64

see

rpmmaker:~ > wget https://github.com/yangao07/abPOA/releases/download/v1.2.5/abPOA-v1.2.5.tar.gz
rpmmaker:~ > tar xf abPOA-v1.2.5.tar.gz
rpmmaker:~ > mkdir build && cd build
rpmmaker:~/build > cmake -DBUILD_SHARED_LIBS=ON -DCMAKE_BUILD_TYPE=Release -DCMAKE_INSTALL_PREFIX=/tmp/abPOA ../abPOA-v1.2.5 && make -j && make install

then 

rpm_maker:build > ldd /tmp/abPOA/bin/abpoa 
    linux-vdso.so.1 (0x00007ffc44cd8000)
    libabpoa.so => not found
    libz.so.1 => /lib64/libz.so.1 (0x00007f6e99c8d000)
    libpthread.so.0 => /lib64/libpthread.so.0 (0x00007f6e99a6d000)
    libm.so.6 => /lib64/libm.so.6 (0x00007f6e996eb000)
    libc.so.6 => /lib64/libc.so.6 (0x00007f6e99326000)
    /lib64/ld-linux-x86-64.so.2 (0x00007f6e99ea4000)
rpm_maker:abPOA-v1.2.5/build > patchelf --print-rpath /tmp/abPOA/bin/abpoa

maybee you should consider adding SET(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/${CMAKE_INSTALL_LIBDIR}") to CMakeLists.txt

yangao07 commented 2 years ago

Fixed this in v1.3.0.