search

yanghaoxie / which-key-posframe

Let emacs-which-key use posframe to show its popup.
GNU General Public License v3.0
51 stars 10 forks source link

Preserve truncation of lines #17

Closed tarsius closed 1 year ago

tarsius commented 2 years ago

Lines are set to be truncated in which-key--init-buffer but because posframe-show always sets truncate-lines based on its :lines-truncate argument, even when that is unspecified (in which case it defaults to nil), we have to double down on this.

eeshugerman commented 2 years ago

Might this close https://github.com/yanghaoxie/which-key-posframe/issues/10?

tarsius commented 2 years ago

It should address the symptoms of that (but I don't really understand how the use of a different font lead to that issue).

On a related note, I've just opened https://github.com/justbur/emacs-which-key/pull/343, which fixes various miscalculations, and those might be the cause of, or at least contribute to, your issue.

tarsius commented 2 years ago

I've added another commit, fixing yet another off-by-one error (in addition to those in which-key).

eeshugerman commented 2 years ago

Sweet 🚀

but I don't really understand how the use of a different font lead to that issue

Yeah, not sure if you saw the second comment there, but the font bit may be a red herring:

UPDATE: This keeps coming back. Changing the font usually (but not always) fixes the issue for a bit, but not forever. So really I have no idea what's going on.

I tweaked the title to reflect that.

Thanks for all the great work!