search

yanghaoxie / which-key-posframe

Let emacs-which-key use posframe to show its popup.
GNU General Public License v3.0
52 stars 10 forks source link

No border shown #6

Open fintelkai opened 4 years ago

fintelkai commented 4 years ago

I have been struggling to get which-key-posframe to show a border around the posframe. I tried a very minimal configuration, with the following as the only contents of init.el:

(load "/Users/fintel/.emacs.d/straight/repos/emacs-which-key/which-key.el")
(load "/Users/fintel/.emacs.d/straight/repos/posframe/posframe.el")
(load "/Users/fintel/.emacs.d/straight/repos/which-key-posframe/which-key-posframe.el")
(which-key-mode)
(which-key-posframe-mode)

But no border appears when the posframe pops up.

Since the presets for the custom variable which-key-posframe-border-width and the face which-key-posframe-border might generate a fairly faint border, I tried other settings, but no border appears.

Any idea what might be going on?

TheBB commented 4 years ago

Just chiming in that I have the same issue. Does not appear to be a problem with any other posframe package (ivy, notably).

knightgu commented 4 years ago

I have same issue. It seems that some attributes can be applied while others cannot. For example, when changing the background color for which-key-posframe, the change does take effect. Changes in which-key-posframe-parameters, though, do not take any effect, nor does changes in which-key-posframe-border. Not sure why the posframe-show function does not apply these changes to the frame.

yanghaoxie commented 4 years ago

Sorry, for the late reply, one of the reason is that I have not figured out how to resolve this issue.

Most of the code is from ivy-posframe, I checked again and did not see any mistakes :(.

If I do not remember wrong, about one year before I had the same issue, but now I can set the border as I want which makes it hard to debug, since I cannot reproduce the issure :(.

BTW, I am now using emacs-28.0.50.

I also tried the following config 

(load "~/.emacs.d/elpa/which-key-20200216.1350/which-key.el")
(load "~/.emacs.d/elpa/posframe-20200426.819/posframe.el")
(load "~/.emacs.d/elpa/which-key-posframe-20190427.1103/which-key-posframe.el")
(which-key-mode)
(which-key-posframe-mode)

and it works fine.

So, I guess maybe the version of Emacs is the issue, please try on Emacs-28.

Cons-Cat commented 3 years ago

If it's worth noting, after displaying the Ivy posframe (with counsel-M-X in this case) at least once on 27.1, the Which-Key posframe border face also displays. GIFRecording