search

yanghengtang / pe

0 stars 0 forks source link

Weight parameter can be made into zero #5

Open yanghengtang opened 11 months ago

yanghengtang commented 11 months ago

The UG states Screenshot 2023-11-17 at 5.05.59 PM.png

And the system outright disallow zero as weight.

However if we enter updatePortion 5 n=Bernice Yu w=0.01/513, we can make the weight to be essentially zero

Screenshot 2023-11-17 at 5.05.32 PM.png

soc-se-bot commented 11 months ago

Team's Response

The weight and subtotal are both displayed as zero but in our application, they are actually recorded as extremely small values. This is not explicitly mentioned in our UG, where we state that portions and balances are rounded off to 2 decimal places. In fact, all numerical values in our application are rounded off to 2 decimal places when they are displayed. Hence it is actually a documentation bug where did not mention that weights and subtotals are also rounded off to 2 decimal places.

image.png

We have labelled this as low severity because it is rare that weights and subtotals are this low. It is unlikely to affect many users, or to significantly impact users.

Items for the Tester to Verify

:question: Issue type

Team chose [type.DocumentationBug] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]

## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]