search

yangl1996 / prism-rust

Rust implementation of the Prism consensus protocol
MIT License
100 stars 19 forks source link

Small problem in Miner #89

Closed wgr523 closed 5 years ago

wgr523 commented 5 years ago

We call new_validated_block for mined_block, what if this block solves data availability for other blocks? Since we broadcast this hash a line before. Can we put broadcast after new_validated_block? https://github.com/yangl1996/prism-rust/blob/56936322ae1135e3d01f64e7e1e6d9173a805883/src/miner/mod.rs#L435-L439

wgr523 commented 5 years ago

in #92

yangl1996 commented 5 years ago

thanks for the fix!