Add neovim support - Githubissues

yangmillstheory / vim-snipe

MIT License

118 stars 8 forks source link

Add neovim support #20

Closed chrhasse closed 6 years ago

chrhasse commented 6 years ago

A couple issues prevent this from being compatible with neovim.

neovim doesn't have v:t_number, using type(0) is the recommended alternative
neovim doesn't allow empty keys in dictionaries (even though the docs say it's allowed). Naive fix is simply adding a space to the end of each key in s:known_modes and concatenating a space to the end of a:mode.

yangmillstheory commented 6 years ago

I'm surprised at the first point - I haven't had issues (even with targets mapped to multi-key sequences) and I'm using neovim? For the second, can we just test a:mode ==# ''?

Also, can you reference the lack of empty string key support in neovim? I'm curious since the docs say otherwise.

chrhasse commented 6 years ago

see comments in #21.