search

yangmillstheory / vim-snipe

MIT License
118 stars 8 forks source link

replaced the rest unchanged 'normal' to 'normal!' #34

Closed Cycl0 closed 2 years ago

yangmillstheory commented 2 years ago

Thanks for the contribution.

It's been a long time since I looked at this code. What bug does this fix, and why's the rationale for merging this PR?

Cycl0 commented 2 years ago

Adding ! to normal is safer as it ignores user mappings, so that the code works as intended, using the native vim keybinds instead of what the user defined those keybinds to do. I noticed other people made PRs but they only fixed their own conflicting problems. e.g: (https://github.com/yangmillstheory/vim-snipe/pull/31)