search

yangqiaosheng / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Unwritten shader output variables crash #862

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
If one binds a render target but does not write to it in the shader, ANGLE 
crashes in DynamicHLSL::FindOutputAtLocation when it tries to match each output 
to a shader variable.

AFAIK the colour of an unwritten output variable is undefined in GL and this is 
an application mistake however ANGLE should not crash either.

Original issue reported on code.google.com by Gregory....@imgtec.com on 7 Jan 2015 at 11:58

GoogleCodeExporter commented 9 years ago 
https://chromium-review.googlesource.com/#/c/239160/

This patch ignores any output which is not written by the shader while 
generating the HLSL.

Original comment by Gregory....@imgtec.com on 7 Jan 2015 at 12:06

GoogleCodeExporter commented 9 years ago 
Closing, as fix is landed.

Original comment by shannonw...@chromium.org on 13 Jan 2015 at 5:14