search

yangqiaosheng / angleproject

Automatically exported from code.google.com/p/angleproject
Other
0 stars 0 forks source link

Refactor Program's InfoLog to use std::stringstream #992

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
This would be a much better fit than using vsprintf and allocating 
re-allocating buffers.

Original issue reported on code.google.com by jmad...@chromium.org on 1 May 2015 at 2:28

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 8ae74e11d2105104737a7425e3bdd68e6329dcfa

Code-Review  0 : Geoff Lang, Jamie Madill
Code-Review  +2: Brandon Jones
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I6328cd03901dbf52eccddc7c747a684ed9b23ea1
Reviewed-at    : https://chromium-review.googlesource.com/268741

Use a std::stringstream for Program's InfoLog.

This should help WebKit avoid needing to apply a local patch.
Also clean up the style in this file a bit.

BUG=angleproject:307,angleproject:992

src/libANGLE/Program.cpp
src/libANGLE/Program.h

Original comment by bugdroid1@chromium.org on 4 May 2015 at 6:05

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 3c74e772eb6d58bd09eea4d87816965c78a0fb93

Code-Review  0 : Geoff Lang
Code-Review  +2: Jamie Madill
Verified     0 : Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : Ifb3658c324cb0aa56ee31352a0fc0e6759979f7b
Reviewed-at    : https://chromium-review.googlesource.com/269848

Revert "Use a std::stringstream for Program's InfoLog."

Missing one character for the log length.

BUG=angleproject:307,angleproject:992

This reverts commit 8ae74e11d2105104737a7425e3bdd68e6329dcfa.

src/libANGLE/Program.cpp
src/libANGLE/Program.h

Original comment by bugdroid1@chromium.org on 7 May 2015 at 2:55

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : f611316bae6d9a85a27941091353908c2bf7990c

Code-Review  0 : Brandon Jones, Jamie Madill
Code-Review  +2: Geoff Lang
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I0ff5d2846175cf19de7a6af295af24a92451456f
Reviewed-at    : https://chromium-review.googlesource.com/268744

Use stream operators for appending to InfoLog.

Also add a helper class to keep the previous behaviour of
automatically appending a newline after every new message.

BUG=angleproject:992

src/libANGLE/Program.cpp
src/libANGLE/Program.h
src/libANGLE/Program_unittest.cpp
src/libANGLE/renderer/d3d/DynamicHLSL.cpp
src/libANGLE/renderer/d3d/HLSLCompiler.cpp
src/libANGLE/renderer/d3d/ProgramD3D.cpp
src/libANGLE/renderer/gl/ProgramGL.cpp

Original comment by bugdroid1@chromium.org on 7 May 2015 at 5:17

GoogleCodeExporter commented 9 years ago 
Project: angle/angle
Branch : master
Author : Jamie Madill <jmadill@chromium.org>
Commit : 71c3b2c7c655d04bf2973eded5695161c5bbfbd1

Code-Review  0 : Brandon Jones, Jamie Madill
Code-Review  +2: Geoff Lang
Verified     0 : Brandon Jones, Geoff Lang
Verified     +1: Jamie Madill
Commit Queue   : Chumped
Change-Id      : I41ecf7cbfa20b469b3731215ef28cb36253ba186
Reviewed-at    : https://chromium-review.googlesource.com/269849

Use a std::stringstream for Program's InfoLog.

This should help WebKit avoid needing to apply a local patch.
Also clean up the style in this file a bit.

BUG=angleproject:307,angleproject:992

src/libANGLE/Program.cpp
src/libANGLE/Program.h
src/libANGLE/Program_unittest.cpp
src/tests/angle_unittests.gypi

Original comment by bugdroid1@chromium.org on 7 May 2015 at 5:17

GoogleCodeExporter commented 9 years ago

Original comment by jmad...@chromium.org on 11 May 2015 at 12:16