search

yangshun / tech-interview-handbook

💯 Curated coding interview preparation materials for busy software engineers
https://www.techinterviewhandbook.org
MIT License
119.09k stars 14.73k forks source link

[feat] add the option for people to contribute tweets #673

Open yehiarasheed opened 1 month ago

yehiarasheed commented 1 month ago

Description

This PR addresses the issue #670, I know that the section listed under the heading Over 1,000,000 people have benefitted from this handbook! is meant for showcasing the benefits of this handbook rather than being accessible to the public like the Success Stories section where users are allowed to contribute their success stories. However the most recent tweets under the first section are from 2022, which is around two years old and that's considered pretty old keeping in mind that the handbook is actually still popular on social media and that we could benefit as contributors and users from using updated information, testimonials and tweets like these that showcase the benefits of this handbook. Therefore, I added the option for users to share their experiences too, just like they have that option under the Success Stories section as could be seen in the screenshots below. I'm considering adding sort of a form on the website later on that automates the process and Pull Requests for programmers that are not very involved with JavaScript (me included haha) so that tweets or success stories can be added through filling a form with the needed details rather than actually changing the website's code, given that you as the project owner can just review the code and the deployment on Vercel and merge right away.

Screenshots

image

Additional Context

I mimicked what you've implemented with the Success stories, I have separated the data (or the stories) from the actual code that displays and renders the stories so that we minimize errors in the code and could later on debug the code easier (Separation of Concerns). I have also maintained the formatting and order of tweets as the original format on the website.

yehiarasheed commented 1 month ago

Note that the hyperlink does not work for now because I've replaced it with the link that is supposed to work after merging, if you are looking for the working hyperlink for now you can access it here.

yehiarasheed commented 4 weeks ago

@yangshun what do you think about the current changes, and concerning the form where users submit data instead of actually making commits in the files themselves and creating a PR?