search

yangsidawh / Android_SimpleTwitter

0 stars 0 forks source link

[Android Bootcamp] Twitter Client - Review my app #1

Open yangsidawh opened 9 years ago

yangsidawh commented 9 years ago

My app is complete, please review. One question about the callback of send tweet. After the post tweet call, I get the whole new tweet back so I just pass it back to the home line and add it to the adapter directly, it saves a request to fetch the whole new tweet list. Is it the right way to do the update or it is better to fetch new tweets from server again? /cc @nesquena @thecodepath

nesquena commented 9 years ago

:+1: Congrats on completing the third project and getting in a few extras! Nice work overall. I have provided a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, Models, Authentication, API Communication, Preferences, ActionBar, et al) and see how they all fit together.

nesquena commented 9 years ago

Is it the right way to do the update or it is better to fetch new tweets from server again?

This is the right way to do it!