search

yangsidawh / Android_SimpleTwitter

0 stars 0 forks source link

[Android Bootcamp] Twitter Client with fragment - Review my app #2

Open yangsidawh opened 9 years ago

yangsidawh commented 9 years ago

My app is complete, please review. One question about data. Actually in this app, I want to load the user data during the launch because both Compose and Profile will need this info. But these two activity doesn't share much business logic, in this case, what is the proper way to share the user data? Similarly, in user profile page, we can find all the basic info we need inside the user timeline response, is it necessary to call another getuserinfo? @nesquena @thecodepath

nesquena commented 9 years ago

:+1: Project looks good. I have provided a detailed Project 4 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you might be able to improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully you can see this coming together as a "fully fledged" twitter client with some more work and polish. This app contains all of the components now (fragments, models, networking, client, tab navigation, image loading, et al) of 90% of dynamic data-driven API client. Obviously there are lots of details and patterns to learn, but by this point you have been introduced to all the major frameworks and concepts. Hopefully you would feel fairly confident getting started making Android apps for instagram, pinterest, yardsale, flickr, using the same patterns.

nesquena commented 9 years ago

But these two activity doesn't share much business logic, in this case, what is the proper way to share the user data? Similarly, in user profile page, we can find all the basic info we need inside the user timeline response, is it necessary to call another getuserinfo?

You can use shared preferences to store data used across all activities. Write the information (user json string) into preferences and then access it across all activities or create a static class used to access that data.