search

yangweigbh / Libgdx-CardBoard-Extension

Android CardBoard SDK development using Libgdx
67 stars 16 forks source link

fixed compatability with new LibGDX #13

Closed EtK2000 closed 7 years ago

EtK2000 commented 7 years ago

changed return type to SnapshotArray<> as apposed to Array<>

EtK2000 commented 7 years ago

Stating that it took my newest pull, I'll change this to the appropriate name.

intrigus commented 7 years ago

It's absolutely impossible to see what you changed.

EtK2000 commented 7 years ago

I know, I kinda rewrote the whole thing. I rewrote it in Android Studio, I presume it formatted some things.

yangweigbh commented 7 years ago

hi EtK2000, thanks for your commit, can you reformat your code and submit again, i can not figure out which part has changed.

EtK2000 commented 7 years ago

Sure, I'll fix it later today. Btw, I think this breaks comparability with older LibGDX in favor of new versions. If so, I'll check which version changed the API.

EtK2000 commented 7 years ago

I have pushed my commit after formatting, now the changes are readable. I also moved some things around to keep the order consistent between this and LibGDX.

EtK2000 commented 7 years ago

Fixed it, thanks for pointing it out.

EtK2000 commented 7 years ago

Don't forget to close issue 9. https://github.com/yangweigbh/Libgdx-CardBoard-Extension/issues/9