Performance issue in the difinition of get_rois, libs/fast_rcnn/build_fast_rcnn.py(P1)

yangxue0827 / R2CNN_FPN_Tensorflow

R2CNN: Rotational Region CNN Based on FPN (Tensorflow)

419 stars 139 forks source link

Performance issue in the difinition of get_rois, libs/fast_rcnn/build_fast_rcnn.py(P1) #82

Closed DLPerf closed 3 years ago

DLPerf commented 3 years ago

Hello, I found a performance issue in the definition of get_rois, libs/fast_rcnn/build_fast_rcnn.py, tf.cast will be created repeatedly in the graph, resulting in reduced efficiency. I think they should be created before the loop.

And the same issues exist in tf.ones, tf.cast in line 122, tf.ones in line 298 and tf.ones in line 306.

Looking forward to your reply. Btw, I am very glad to create a PR to fix it if you are too busy.

yangxue0827 commented 3 years ago

This repo has been deprecated, I currently maintain yangxue0827/RotationDetection.

DLPerf commented 3 years ago

This repo has been deprecated, I currently maintain yangxue0827/RotationDetection. All right.