search

yangyuan / hearthrock

Hearthstone® Bot Engine
https://yangyuan.github.io/hearthrock/
MIT License
258 stars 68 forks source link

GetMininWastedCost param #58

Closed BryanNoller closed 6 years ago

BryanNoller commented 6 years ago

Am I missing something or is the RockId param passed to GetMininWastedCost really unused? https://github.com/yangyuan/hearthrock/blob/c4de31f328e88e5f3ed4007727c148ec2e711940/src/Hearthrock.Bot/Score/RockSceneContext.cs#L55-L76

yangyuan commented 6 years ago

Yes, it's totally unused. That is a part of an unfinished feature. I was focusing on other things and didn't get time to finish it. (maybe I should remove it first)

BryanNoller commented 6 years ago

ok, was just curious. came across it while porting the c# bot over to python to have a decent base to work with.