[AndriodBootCamp] Week 3 project review request

yangyzheng commented 9 years ago

To @nesquena and @thecodepath, please review my 3rd week project. Still working on the persistence...

Thanks a lot!

Yang

codepathreview commented 9 years ago

:+1: nice work Yang. A few notes after checking out the code:

Your attention to UI was impressive, looks very clean
Good to see you were able to format the timestamp cleanly
Good to see you refreshed the timeline after composing a new tweet
Nice touch with the character count being displayed while the user composes a tweet by using TextWatcher
Nice to see you used a PullToRefresh library for easy timeline refreshes
Good to see you added ActiveAndroid annotations to the models
Consider adding progress bars to your app whenever a network request goes out
Consider better organizing your source files

Here's a detailed Project 3 Feedback Guide here which covers the most common issues with this submitted project. Read through the feedback guide point-by-point to determine how you could improve your submission.

Let us know if you have any other thoughts or questions about this assignment. Hopefully by now you feel pretty comfortable with all the major pieces to basic Android apps (Views, Controllers, ActionBar, Navigation, Models, Authentication, API Communication, Persistence, et al) and see how they all fit together. We are close now to a turning point in the course where you should be hitting a "critical mass" towards your knowledge of Android.

codepathreview commented 9 years ago

About your questions :

favourites_count is present in all timeline APIs response, it is part of each tweet object. Check here - https://dev.twitter.com/rest/reference/get/statuses/home_timeline
Yes, if we want to develop reusable pieces in Android, we make them as fragments.

yangyzheng / SimpleTwitterClient

[AndriodBootCamp] Week 3 project review request #1