search

yanivam / react-svg-worldmap

A simple, compact and free React SVG world map.
MIT License
117 stars 45 forks source link

feat: export list of regions #119

Closed warenbe closed 2 years ago

warenbe commented 2 years ago

Hi Added an export for the country list each country is an object like 

{
  name: "name of the country",
  code: "2 letter code (US for example)"
}

feel free to tell me if i made a mistake as it's first time i use pull in github.

Close #116

Josh-Cena commented 2 years ago

Could you either use Yarn v1 to install, or add yarnPath (and commit the yarn-3.2.0.cjs file)? Yarn berry is not recommended to be installed globally.

warenbe commented 2 years ago

well, i have an error when i use yarn v1 i fixed it with latest yarn probably my setup.

Josh-Cena commented 2 years ago

What's the error?

I would revert this change before merging anyways, but still curious to know, in case you need help

warenbe commented 2 years ago

well i think this is a problem between github desktop and yarn something about impossibility to find path of cygpath

Josh-Cena commented 2 years ago

Well... Isn't something I can help with, then. I don't think it has anything to do with GH desktop because AFAIK that doesn't change any environment settings but only connects to the git client. It seems you are using Windows which I'm even less familiar with, so that's it.

I would make some reverts and merge this. Thanks a lot!

warenbe commented 2 years ago

well, i tried and it seems i can commit with command line, but not from GH desktop. apparently i'm not the only one to have this issue. anyway, thank for the works and the modification ;) i find this library very usefull: simple, clean.