search

yankaindustries / mc-components

Components library and core styles for Masterclass
https://yankaindustries.github.io/mc-components
11 stars 3 forks source link

Fix end screen blocking clicks #747

Closed bernabe9 closed 4 years ago

bernabe9 commented 4 years ago

Overview

After the end screen exits, the user wasn't able to interact with the video player clicking the screen for pausing or resuming.

Looks like a wrong state of the transition was adding a class to the end screen component when it should be hidden. image (30)

More info here: https://masterclass-dev.atlassian.net/browse/WE-202

Risks

Medium. Not sure why we had that function for defining when the transition ends, but maybe the code reviewers can clarify this.

Breaking change?

No

jstnjns commented 4 years ago

do screens properly transition out? or just hide immediately? i don't see a lot of value in them transitioning i suppose other than aesthetic

bernabe9 commented 4 years ago

@jstnjns I have added a timeout, so now the start screen and pause screen have a transition out