search

yanlesin / SEC13Flist

Returns a data frame with SEC Official List of Section 13F Securities for given Year and Quarter by parsing official list
Creative Commons Zero v1.0 Universal
7 stars 1 forks source link

Fix URL logic for dates after Q2 2021 #71

Closed realmadsci closed 2 years ago

realmadsci commented 2 years ago

url_file_func() logic to determine file path on sec.gov was incorrect starting in Q1 2022. This fix repairs the "rollover" issue and also puts the "date decoders" in chronological order for easier readability.

yanlesin commented 2 years ago

@realmadsci it looks like there are also changes to SEC file itself... I will check later this evening and correct those. Will need it shortly myself...

realmadsci commented 2 years ago

Thank you!

yanlesin commented 2 years ago

@realmadsci, i found that checks are failing due to need to replicate url_file_func() logic in test file test-SEC_row_count.R. I will accept your pull request and change test code after that to replicate your logic in proposed pull request. I appreciate your contribution!