search

yanlesin / SEC13Flist

Returns a data frame with SEC Official List of Section 13F Securities for given Year and Quarter by parsing official list
Creative Commons Zero v1.0 Universal
7 stars 1 forks source link

Remove `tidyr` dependency by re-implementing `filldown` function #83

Closed yanlesin closed 11 months ago

yanlesin commented 1 year ago

fill function is the only dependency in the package that requires tidyr. It is possible to include cpp filldown from tidyr as non-exported function, in order to remove dependency. The remaining dependencies will be pdftools and rvest. rvest changed in the past and broke functionality and should be considered for removing as dependency. pdftools - ok to have it as dependency.

yanlesin commented 12 months ago

filldown in tidyr is replaced now with functions from vctrs. Will investigate if I can re-implement vctrs version

yanlesin commented 11 months ago

Will close this issue for now - recent profiling of function show almost no impact from use of fill function.