Added password show/hide toggle for password fields

yann-yinn / adonis-starter

A Node.js / TypeScript / Postgres starter with ready-to-use users management (register, login, forgot password etc) to focus on building your new ideas. Built upon the excellent AdonisJS MVC Framework.

71 stars 15 forks source link

Added password show/hide toggle for password fields #18

Closed Sreejit7 closed 3 years ago

Sreejit7 commented 3 years ago

Added password show/hide toggles for all password and confirm password fields.

@yann-yinn I've also added a partial for password but since the field has many different fields at different I'm not sure how reusable it will be.

yann-yinn commented 3 years ago

Thanks, I will review this ASAP !

yann-yinn commented 3 years ago

hi @Sreejit7 , So first, amazing job, it works really well and that's a very important feature for UX, so thank you for this contribution :)

I read the PR. Here are my recommendations:

1) major: there are JS errors because JS is included on every page, but DOM element for password does not exist on every page.

My suggestion would be to create a components for password fields, and include Githubissues.

Githubissues is a development platform for aggregating issues.