search

yannbf / ionic3-components

A project full of ionic 3 components and samples - to make life easier :)
MIT License
1.68k stars 704 forks source link

added team page #89

Closed asabya closed 4 years ago

asabya commented 6 years ago

A team members page showing team member images in ion-tab and displaying their info in another page. team

asabya commented 6 years ago

Hi @yannbf, did you get any chance to review this? Thanks

yannbf commented 4 years ago

Hey @Sab94 ! I am terribly sorry for not having reviewed this PR. I've been away for quite a long time, now I am trying to catch up again.

Great contribution, thanks a lot for that!

yannbf commented 4 years ago

@all-contributors please add @Sab94 for code and design

allcontributors[bot] commented 4 years ago

@yannbf

I've put up a pull request to add @Sab94! :tada:

asabya commented 4 years ago

@yannbf Thanks for taking the time to merge it. After this pr ionic released v4 and I stopped working on ionic3 as well as ionic and moved on. Anyway I think this will help others in need.

yannbf commented 4 years ago

@yannbf Thanks for taking the time to merge it. After this pr ionic released v4 and I stopped working on ionic3 as well as ionic and moved on. Anyway I think this will help others in need.

Indeed! Moving from ionic 3 to 4 in this repo is quite an effort, and given that I am not currently focusing on ionic, I am planning just to park it the way it is, as it can be helpful indeed to people who are using Ionic 3.