search

yanncabral / open_settings_plus

The most complete flutter plugin packages for open various settings screen in Android and newer iOS.
MIT License
18 stars 13 forks source link

(fix android): Remove android ndk declaration in build.gradle #12

Closed Petrol- closed 7 months ago

Petrol- commented 7 months ago

Hello,

This PR removes the NDK declaration in Android build.gradle file.

The NDK should not be needed since there is no C/C++ dependencies involved in this package.

This should remove a warning when compiling an Android app without ndk declaration:

One or more plugins require a higher Android NDK version.
Fix this issue by adding the following to /your_project/android/app/build.gradle:
android {
  ndkVersion "25.1.8937393"
  ...
}

Please let me know if further changes are needed. Thank you

yanncabral commented 7 months ago

Hello,

Thank you for submitting this pull request. As I primarily work with iOS, contributions that enhance our Android ecosystem are particularly valuable. I have thoroughly tested the changes you proposed and can confirm that the removal of the NDK declaration indeed eliminates the related compilation warning effectively. Your proactive approach not only resolves an important issue but also improves the development experience for all users of this package.

We greatly appreciate the quality and insightfulness of your contribution, which helps us maintain the high standards our project aspires to. I will be merging this PR shortly.

Thank you once again for your valuable input and for supporting our Android platform. We look forward to your continued involvement and innovative solutions.

Warm regards, Yann Cabral