search

yanne / api-test

0 stars 0 forks source link

`Get Connections` keyword allows overriding the default log level #79

Closed yanne closed 10 years ago

yanne commented 10 years ago

Currently, Read, Read Until, Read Until Prompt, Read Until Regexp, Write, Write Until Expected all log the read output from the server. Similarly, these keywords allow overriding the default log level (set either on library importing or later by using keyword Set Default Configuration) by allowing argument loglevel to any of these keywords.

In a same way, Get Connections currently logs the connection information with the default log level. Similarly, it should allow overriding the default log level. This change is mainly for consistency and to make loglevel documentation a bit more clear.

This issue was originally opened at Google Code on Aug 26, 2013.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Aug 26, 2013.

This is done by https://code.google.com/p/robotframework-sshlibrary/source/detail?r=211d44bbb5c2e314db4fdb016fb7d5d93531d9cf

yanne commented 10 years ago

Original comment by pekka.klarck on Oct 17, 2013.

Looks good.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Oct 22, 2013.

This issue was updated by revision e3c4cfb4d0c6 .

In the end, we decided that the connection information can always be logged by keywords Get Connections and Get Connection (done in issue 72 ) with log level INFO and to not add loglevel argument for these keywords.

This is also due to fact that Get Connection supports configuring its arguments so that plain connection attributes can be returned ( issue 72 ). Thus, when using positional arguments, having to first pass loglevel argument would probably cause more confusion there.