search

yanne / api-test

0 stars 0 forks source link

`Write` keywords should not require prompt to be set #80

Closed yanne closed 10 years ago

yanne commented 10 years ago

Write keywords (Write, Write Bare and Write Until Expected Output) seem to require prompt to be set before they can be used. There seems to be no valid reason for this behaviour and prompt is not actually used by any of those keywords.

The only keyword that actually needs to have the prompt configured is Read Until Prompt.

This issue was originally opened at Google Code on Aug 29, 2013.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Aug 29, 2013.

This is done by commit https://code.google.com/p/robotframework-sshlibrary/source/detail?r=a396367bf4ab68adab5cce30857f5d25e466b3ff

yanne commented 10 years ago

Original comment by pekka.klarck on Oct 17, 2013.

I totally agree that Write and friends don't need prompt to be set. It's definitely enough that Read Until Prompt fails with a clear error message if prompt hasn't been set.