Return server output after login correctly and also log it

[yanne]

The following test case fails with Pybot:

Open Connection hostname.com ${motd} = Login username password Should Contain ${motd} Last Login:

With Pybot, keyword Login returns an empty string as ${motd} when it should return the output available on the server (usually the MOTD). With Paramiko, the server output seems not to be available at that point. This can be fixed by returning from Login keyword only after a non-empty string is read.

On Python and Jython, everything already works correctly if prompt is set:

Open Connection hostname.com prompt=$ ${motd} = Login username password Should Contain ${motd} Last Login:

This issue was originally opened at Google Code on Sep 2, 2013.

[yanne]

Original comment by anssi.sy...@eficode.com on Sep 2, 2013.

This was fixed, and the missing tests were added by https://code.google.com/p/robotframework-sshlibrary/source/detail?r=64c94837822567033d9c57544fcb0aae3956f4cd

[yanne]

Original comment by pekka.klarck on Oct 17, 2013.

This looks good otherwise, but the having while True loop is a bit risky. Basically the code would hang if there is no output from the server. We agreed that a better approach is having a maximum time to wait. In addition to that, we agreed that after a successful read we should still try to read more after a small delay. Both of these will be trivial to implement after Read keyword has been enhancement to support delays ( issue 90 ).

[yanne]

Original comment by anssi.sy...@eficode.com on Oct 28, 2013.

This is done in revision 04abc8f0dbd4 (accidentally used the wrong issue number in the commit message).

[yanne]

Original comment by anssi.sy...@eficode.com on Oct 29, 2013.

This issue was updated by revision d8ec9f88390c .

Keywords Login and Login With Public Key now also log the read output with loglevel 'INFO'.

[yanne]

Original comment by pekka.klarck on Oct 30, 2013.

Looks good. In the review we agreed about few small doc enhancements and changing these keywords to log the output using the default log level. After those changes this issue can be closed.

[yanne]

Original comment by anssi.sy...@eficode.com on Oct 30, 2013.

This issue was updated by revision b1152639e2f1 .

• The default log level is now used instead of always logging with INFO
• Included login keywords to the default log level documentation
• Also added a recommendation to set the prompt if it is known in advance

[yanne]

Original comment by robotframework@gmail.com on Oct 30, 2013.

This issue was updated by revision c08c41dc168c .

Enhanced docs a little more. Now definitely done.