search

yanne / api-test

0 stars 0 forks source link

Path separator should be configurable per connection #93

Closed yanne closed 10 years ago

yanne commented 10 years ago

It would make more sense to have path separator configurable per connection instead of passing it as an argument path_separator to keywords Get File, Put File, Get Directory and Put Directory since the need for configuring the path separator solely depends on the remote host.

This issue was originally opened at Google Code on Nov 18, 2013.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Nov 18, 2013.

This issue was updated by revision f4d09575d6dd .

The path separator is now configurable as a library default and can be overridden per connection (as an argument to Open Connection).

Argument path_separator was removed from Get And Put variants.

Also updated the documentation related to the changes.

yanne commented 10 years ago

Original comment by anssi.sy...@eficode.com on Nov 18, 2013.

This issue was updated by revision c619356ba74d .

Actually forgot that this needs to be deprecated first, so argument path_separator now still works for Get File and Put File as before but will trigger a deprecation warning. If the value is not given, the library or the connection setting is used instead, as with the most of the other settings.

yanne commented 10 years ago

Original comment by pekka.klarck on Nov 19, 2013.

This issue was updated by revision c2606214321d .

Looks good. Enhanced docs a little.