search

yanne / api-test

0 stars 0 forks source link

Timeout should affect all commands #96

Closed yanne closed 10 years ago

yanne commented 10 years ago

The following commands do not use SSHLibrary built-in timeout:

This issue was originally opened at Google Code on Jan 8, 2014.

yanne commented 10 years ago

Original comment by mikko.ko...@gmail.com on Jan 8, 2014.

This is problematic as these keywords can take a lot of time or hang indefinitely

@see Issue 95

yanne commented 10 years ago

Original comment by tatu.ka...@eficode.com on Jan 8, 2014.

It is weird that you have to set the timeout in Library import but is only used in some keywords. Also other libraries (Selenium2Library) have the convention that timeout specified in Library import concern all keywords.

If it's too tricky to implement "global" timeout for all keywords, the timeout setting should be either moved as an additional argument to the relevant keywords or the setting should be provided as its own keyword (à la SwingLibrary)

yanne commented 10 years ago

Original comment by mikko.ko...@gmail.com on Jan 27, 2014.

The timeout in Library import only affects Read Until... keywords as detailed in documentation.

It's not sensible to have global timeout for all keywords.