Closed tricktron closed 1 year ago
That's super interesting, thanks, will definitely consider! Def. could replace the script in the scripts/ in this repo. Very similar, there is this https://github.com/yannh/openapi2jsonschema that generates the files in this repo https://github.com/yannh/kubernetes-json-schema/
If you were interested in evolving your script so it can be used to update the kubernetes-json-schema repo, I would be pretty delighted in retiring the Python version!
Yeah, I have seen your https://github.com/yannh/openapi2jsonschema script as well. What do you think about an incremental approach: First check and see if all works with crds and if all is well I think about extending it to support the kubernetes json schema use case.
Definitely :bow: no promises on a timeline, but I'll look into this at some point :heart:
@tricktron I'll be closing this issue, but thanks for pointing this out. I am likely to ask people encountering issues to give it a shot and provide feedback :bow: Thanks :1st_place_medal:
hi i have tested your js script and it produces the same output as the script in this repository but add the dependency to the node_module
so right now i do not see any benefit here
update: i see the -a
option could be a good reason for your script. or we can add this to the python script as well?
Hi there,
I am the author of crd2jsonschema and this may be a good fit for an alternative to your openapi2jsonschema.py script.
crd2jsonschema uses openapi-schema-to-json-schema library under the hood which converts openAPI v3 to jsonschema draft 4. See also https://github.com/datreeio/CRDs-catalog/pull/142#issuecomment-1476277143 for more info.