yannh / kubeconform

A FAST Kubernetes manifests validator, with support for Custom Resources!
Apache License 2.0
2.15k stars 121 forks source link

Support multi-architecture Docker image #196

Closed denisa closed 1 year ago

denisa commented 1 year ago

Apple is transitioning its computer to a arm64 architecture

While amd64 can be executed, sometime, this is slower.

Could the project build an image that supports both amd64 and arm64?.

yannh commented 1 year ago

What would you think of arm64 images, like with a -arm64 suffix? That should be pretty trivial to add :)

denisa commented 1 year ago

Do you mean https://goreleaser.com/cookbooks/multi-platform-docker-images/?h=multi ?

In the ideal end-state, there is a single image and docker dynamically downloads what’s appropriate at execution time

yannh commented 1 year ago

I tried adding support for separate arm64 images here https://github.com/yannh/kubeconform/actions/runs/4971934488/jobs/8896808560 but hit some issues and reverted for now. This is also pretty difficult for me to test - since I do not own a mac. I don't have much more time today, but would happily merge PRs to add support here. Also happy to add support for multi-arch images.

denisa commented 1 year ago

See https://github.com/yannh/kubeconform/pull/204

yannh commented 1 year ago

Closing, since the PR has been merged, thanks!

yannh commented 1 year ago

Closing, since the PR has been merged, thanks!