search

yannh / redis-dump-go

Backup & Restore your Redis server - FAST
MIT License
274 stars 58 forks source link

Support for cluster mode #13

Closed anis028 closed 3 years ago

anis028 commented 3 years ago

How can I take backup for redis running on cluster mode using redis-dump-go?

yannh commented 3 years ago

Hi @anis028 , I haven't looked into this - I assume it doesnt work right now? What error are you seeing?

anis028 commented 3 years ago

Hi @yannh , Not error actually. But i am not sure how to manage it. If i run redis-dump-go on a master of a cluster, it writes only the keys that are stored in that master. So, when restoring it becomes a problem. If I feed the dump.resp file to a master if the slots of the keys are not currently served by this master, it gives error. Only the keys that falls under the current master is restored. So if a dump file has key with slots that are currently split between masters, it becomes redundant operation. Feeding each dump file to each master seems troublesome, also problematic from the perspective of performance.

yannh commented 3 years ago

@anis028 https://redislabs.com/redis-enterprise/technology/backup-disaster-recovery/ seems to indicate backing up individual shards? I am not very familiar with backups of redis clusters unfortunately.

anis028 commented 3 years ago

@yannh i think that is the process in which the dump.rdb and appendonly.aof files are used. They are the part of redis persistence. But I was trying to do with your redis-dump-go project, and was wondering if you guys did something for backup of clustering mode.

yannh commented 3 years ago

No, redis-dump-go has never been tested to work on Clustered Redis (yet).

anis028 commented 3 years ago

Do you guys have any plans for incorporating the feature of redis cluster backup in near future?

yannh commented 3 years ago

No, though I would probably accept patches going in that direction... Right now I am not sure what would be required.

yannh commented 3 years ago

Closing for now!

AbdullahAlShaad commented 1 year ago

Any update about this ? Is redis-dump-go tested for redis cluster mode ?