Closed Emon46 closed 2 years ago
Thanks a lot @Emon46 , I will look into this later this week! Any test, whether unit or integration would make it easier to review :)
Do you think that instead of having your function return a pool, it could return an array of DialOpts? We could build the customConnFunc + RadixPool in DumpDB where it used to be, and it would be pretty trivial then to add a test for your new function... wdyt?
Hey @yannh @Emon46 . Do you have any ETA for this? We needed this lately. Thanks for the great work.
Hi @yannh and @Emon46 ! We are also interested in this feature to be developed. Just wondering if this will be developed soon or has it been delayed? Thanks in advance!
Still around o/ I don't need the feature myself so it is a bit low on my priorities, and I think this PR needs a little bit more work & tests... I might get there, but I prefer delaying this until I am happy with it, than merging something that might not be working perfectly and then not being able to support it :bow:
Hi @Emon46 , I am currently working on a new PR heavily inspired from yours: https://github.com/yannh/redis-dump-go/pull/30 If I do not find the time to add acceptance tests to demonstrate SSL support I might merge it anyway :thinking: I will see if I can add you as a co-author in the Commit to give credit where credit is due :bow:
superseded by https://github.com/yannh/redis-dump-go/pull/30
Didnt get to acceptance tests but at least added a fair amount of unit tests https://github.com/yannh/redis-dump-go/pull/31 :)
Released 0.6.0
Signed-off-by: Emon46 emon@appscode.com