yannh / redis-dump-go

Backup & Restore your Redis server - FAST
MIT License
274 stars 58 forks source link

Auth issues with the latest build #35

Closed samitpal closed 2 years ago

samitpal commented 2 years ago

I'm getting authentication error with the latest build. It was working fine with version 0.5.1. Seems like getDBIndexes function is not using the password. Can the auth error be because of that?

yannh commented 2 years ago

I will look into this very soon and add tests around it :)

yannh commented 2 years ago

I've pushed a fix - repeats some code but should work :) I also added an acceptance test to test connections with a password. As soon as Github actions works again I'll publish a new release :+1:

yannh commented 2 years ago

Alright code should now be nicer and avoid unnecessary duplication... and the bug is fixed, as attested by the new acceptance tests :) Tagged v0.7.0