search

yannickl / Splitflap

A simple split-flap display for your Swift applications
http://cocoadocs.org/docsets/Splitflap
MIT License
1.08k stars 79 forks source link

Don't show lines when color is set to nil #10

Closed mdmack closed 5 years ago

mdmack commented 5 years ago

When a user sets the line color to "nil", don't display any lines. The reason I did this is due to line removal. I can set the line color to clear, then I only see one line. But if I set it to nil, I see two. So I think the subviews shouldn't be added and it will remove those lines entirely. There is a very very faint line, but almost looks gone. Thanks, Mike

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #10   +/-   ##
=======================================
  Coverage   80.05%   80.05%           
=======================================
  Files          15       15           
  Lines         371      371           
=======================================
  Hits          297      297           
  Misses         74       74
Impacted Files Coverage Δ
Sources/TileView.swift 100% <ø> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fb77534...9a60901. Read the comment docs.

yannickl commented 5 years ago

This is a good point, thank you for your help!