yannisl / noto

Automatically exported from code.google.com/p/noto
0 stars 0 forks source link

Noto Naskh importnant issue in GC "Only!" #128

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I installed Noto Naskh in a magazine website and I noticed that it has an issue 
with Google Chrome only!

If you write مبدئي، رئيس the word break in GC (Win)...

You can see the attached files...

In Mac All letters are broken... No issues in other browsers...

What version of the product are you using? 
The last one, downloaded last week

On what operating system? Win & Mac

Please provide any additional information below.

Original issue reported on code.google.com by oussama....@gmail.com on 11 Aug 2014 at 5:58

Attachments:

GoogleCodeExporter commented 9 years ago
Would you please mention the version of Chrome and the version of Noto Naskh 
you are using? Thanks.

Original comment by roozbeh@google.com on 28 Aug 2014 at 5:23

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
It was Version 36.0.1985.143 m and now it is Version 37.0.2062.94 m. Noto 
version is 1.00. Thanks

Original comment by oussama....@gmail.com on 28 Aug 2014 at 6:01

GoogleCodeExporter commented 9 years ago
That might be a CoreText issue, in which case it will be fixed when we switch 
Chrome Mac to use HarfBuzz.

Original comment by beh...@chromium.org on 30 Aug 2014 at 10:25

GoogleCodeExporter commented 9 years ago
I use Windows & Mac, the issue is the same:-) 

Original comment by oussama....@gmail.com on 30 Aug 2014 at 1:01

GoogleCodeExporter commented 9 years ago
Please provide a website example that shows the bug.

Original comment by beh...@chromium.org on 30 Sep 2014 at 2:46

GoogleCodeExporter commented 9 years ago
http://sehha.eu/

Original comment by oussama....@gmail.com on 30 Sep 2014 at 3:14

GoogleCodeExporter commented 9 years ago
Ok, two separate things going on:

  - The version of Noto Naskh Arabic that we are serving in Google Fonts seems to be badly broken in GDEF/GPOS tables.  Here's what latest github/khaledhosny/ots says about it:

"""
"""

  - Google Chrome's version of OTS is older than Firefox, and will drop GSUB table if any of GDEF/GPOS was dropped (which is the case here), resulting in HarfBuzz doing fallback Arabic shaping, which doesn't handle YEH WITH HAMZA character (by design).

The fixes are:

  1. investigate why Noto Naskh Arabic that we serve is broken and fix it (roozbeh / webfonts team),

  2. Switch Google Chrome to github OTS (me).

Original comment by beh...@chromium.org on 30 Sep 2014 at 3:38

GoogleCodeExporter commented 9 years ago
Here's the OTS log:

DEF: bad contour indeces: 30 >= 30
GDEF: Invalid attachment list, table discarded
Layout: lookup flag asks for mark attachment that is bad 256
Layout: Failed to parse lookup 6
GPOS: Failed to parse lookup list table, table discarded

Original comment by beh...@chromium.org on 30 Sep 2014 at 3:41

GoogleCodeExporter commented 9 years ago
Here's a one-line test case:

data:text/html;charset=utf-8,<body><head><style>@font-face {font-family: 'Noto 
Naskh Arabic'; src: 
url(http://fonts.gstatic.com/ea/notonaskharabic/v2/NotoNaskhArabic-Regular.ttf) 
format('truetype');} body{font-family: 'Noto Naskh 
Arabic';}</style><body>%D8%A8%D8%A6%D8%A8

Original comment by beh...@chromium.org on 30 Sep 2014 at 3:43

GoogleCodeExporter commented 9 years ago
Or better:

data:text/html;charset=utf-8,<body><head><style>@font-face {font-family: 'Noto 
Naskh Arabic'; src: 
url(http://fonts.gstatic.com/ea/notonaskharabic/v2/NotoNaskhArabic-Regular.ttf) 
format('truetype');} body{font-family: 'Noto Naskh Arabic';}</style><body>بئب

Original comment by beh...@chromium.org on 30 Sep 2014 at 3:44

GoogleCodeExporter commented 9 years ago

Original comment by behdad@google.com on 30 Sep 2014 at 3:44

GoogleCodeExporter commented 9 years ago

Original comment by behdad@google.com on 30 Sep 2014 at 3:45

GoogleCodeExporter commented 9 years ago
Hi all,

I noticed a big issue in this font when I use Mac OS. Actually, all letters are 
disconnected and not cursive as what I see in Windows.

My site of test is: www.sehha.eu

Original comment by oussama....@gmail.com on 5 Oct 2014 at 10:46

GoogleCodeExporter commented 9 years ago
Correct.  Same analysis as before.

Original comment by beh...@chromium.org on 6 Oct 2014 at 5:41

GoogleCodeExporter commented 9 years ago
Is this something that you can resolve quickly or we have to move to other font?

Thank you.

Original comment by oussama....@gmail.com on 7 Oct 2014 at 2:34

GoogleCodeExporter commented 9 years ago
Working on it right now.  We should be able to fix this very quickly.

Original comment by beh...@chromium.org on 7 Oct 2014 at 8:10

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Roozbeh filed https://code.google.com/p/noto/issues/detail?id=172 for same 
issue on other fonts.

Original comment by beh...@chromium.org on 7 Oct 2014 at 8:20

GoogleCodeExporter commented 9 years ago
Roozbeh, I looked into NotoNaskhArabic-Regular.  Here's the ot-sanitize output:

GDEF: bad contour indeces: 30 >= 30
GDEF: Invalid attachment list, table discarded

I checked the AttachList table.  It definitely has some bogus items, eg:

      <AttachPoint index="927"> 
        <!-- PointCount=3 --> 
        <PointIndex index="0" value="22"/> 
        <PointIndex index="1" value="23"/> 
        <PointIndex index="2" value="23"/> 
      </AttachPoint> 
      <AttachPoint index="928"> 
        <!-- PointCount=3 --> 
        <PointIndex index="0" value="22"/> 
        <PointIndex index="1" value="23"/> 
        <PointIndex index="2" value="23"/> 
      </AttachPoint> 

I'm not surprised if it has values that make ots unhappy.  We should either 
drop all AttachList tables from the fonts, or create them ourselves and do it 
correctly.

The next issue:

Layout: lookup flag asks for mark attachment that is bad 256
Layout: Failed to parse lookup 6

This is simply a result of GDEF being dropped now, so will be fixed if GDEF is 
fixed.

The fact that we are dropping these tables at all is completely bogus IMO.

Anyway, CC'ing Khaled just so he's in the loop.

So, can you fix this in the fonts and then pass on to Webfonts team to update 
what we are serving?

Original comment by beh...@chromium.org on 8 Oct 2014 at 1:03

GoogleCodeExporter commented 9 years ago
This issue was closed by revision a6729509dcc1.

Original comment by roozbeh@google.com on 8 Oct 2014 at 3:03

GoogleCodeExporter commented 9 years ago
This should make it to Google Fonts in a day or two.  Please reopen if it 
doesn't.

Original comment by behdad@google.com on 8 Oct 2014 at 3:33

GoogleCodeExporter commented 9 years ago
ReOpen,

Thanks for the update, the issue is partially resolved: OK for the Mac but the 
original issue continues in the PC. Could you please review your solution as 
soon as soon as possible

Original comment by oussama....@gmail.com on 14 Oct 2014 at 5:52

GoogleCodeExporter commented 9 years ago
I still see the problem on Linux as well.  Let me check.

Original comment by beh...@chromium.org on 14 Oct 2014 at 5:56

GoogleCodeExporter commented 9 years ago
New fonts have not been pushed to the servers yet.  So I'm not sure how the Mac 
issue is fixed.  (are you on Chrome 40 perhaps?  In which case you should get 
the same behavior as other platforms).

At any rate, please retry in about 24 hours.

Original comment by beh...@chromium.org on 14 Oct 2014 at 6:05

GoogleCodeExporter commented 9 years ago
I updated to GC 38.0.2125.101 m and it is even worst: all the font is broken in 
Windows!

Original comment by oussama....@gmail.com on 14 Oct 2014 at 10:30

GoogleCodeExporter commented 9 years ago
Ok, it's fixed now:

data:text/html;charset=utf-8,<body><head><style>@font-face {font-family: 'Noto 
Naskh Arabic'; src: 
url(http://fonts.gstatic.com/ea/notonaskharabic/v3/NotoNaskhArabic-Regular.ttf) 
format('truetype');} body{font-family: 'Noto Naskh 
Arabic';}</style><body>%D8%A8%D8%A6%D8%A8

Humm, what do you mean it's broken on Windows.  Please clarify / attach 
screenshot.

Original comment by beh...@chromium.org on 15 Oct 2014 at 4:16

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
My web site is: www.sehha.eu

GC/Win: Version 38.0.2125.104 m

I downloaded the font that you are giving in your message and it is working in 
Windows, I suppose it works also in Mac.

Thank you for your support. 

I am looking to show this font in the next coming (December) Arabic Typography 
portal. www.aratypo.net

Original comment by oussama....@gmail.com on 15 Oct 2014 at 4:51

GoogleCodeExporter commented 9 years ago
Verified by the original reporter.

Original comment by roozbeh@google.com on 15 Oct 2014 at 4:54