search

yannjor / krabby

Print pokemon sprites in your terminal
GNU General Public License v3.0
124 stars 8 forks source link

Add shell completions #4

Open yannjor opened 2 years ago

yannjor commented 2 years ago

Add shell completions for the name command. This should be possible with clap. See: https://dev.to/kbknapp/cli-shell-completions-in-rust-37g1

rafaeljacov commented 3 weeks ago

Hello, I'm currently implementing it, would you advise if I should generate the completions at compile-time or at runtime instead? (PS. This will be my first ever contribution in open source)

yannjor commented 3 weeks ago

Hey @rafaeljacov ! Awesome that you want to contribute. Complile-time would probably be better in terms of performance.

rafaeljacov commented 3 weeks ago

Hey @rafaeljacov ! Awesome that you want to contribute. Complile-time would probably be better in terms of performance.

that's what I thought too but since starship and zoxide both implement it in runtime I just went with it also because it is really easy to source it in the shell config for the user