search

yannrichet / rsession

R sessions wrapping for Java
BSD 2-Clause "Simplified" License
52 stars 31 forks source link

fix bug for quote expressions in R2js #36

Closed yannrichet closed 4 years ago

yannrichet commented 4 years ago

see https://travis-ci.org/github/yannrichet/rsession/jobs/725915574 for https://github.com/yannrichet/rsession/tree/bug-quote_expr :

        assert engine.eval("paste(sep='<br/>',\n"
                + "        paste('<HTML name=\"minimum\">minimum is ',0.1),\n"
                + "        paste(sep='',\n"
                + "            'found at ',\n"
                + "            paste(collapse='; ',paste(c('x1','x2'),'=',c(.5,.6))),\n"
                + "            '<br/><img src=\"',\n"
                + "            'files',\n"
                + "            '\" width=\"',600,'\" height=\"',600,\n"
                + "            '\"/></HTML>'))").toString().contains("\"minimum\"");

is ok, while

        assert engine.eval("paste0(\"<HTML name='minimum'>minimum is \",0.1,\n"
                + "                \" found at \",\n"
                + "                paste0(paste(c('x1','x2'),'=',c(.5,.6), collapse=';')),\n"
                + "                \"<br/><img src='\",\n"
                + "                \"files\",\n"
                + "                \"' width='600' height='600'/></HTML>\")").toString().contains("'minimum'");

fails and returns QUOTEEXPRESSION....

nchabalier commented 4 years ago

Fixed in bc3eba497acccb5cc9cf6373472d0ddf36748b7e